fix: pass topOriginValidator to CheckTopOrigin in requestCeremony()#821
Merged
fix: pass topOriginValidator to CheckTopOrigin in requestCeremony()#821
Conversation
The custom TopOriginValidator set via enableTopOriginValidator() was only passed to CheckTopOrigin in creationCeremony() but not in requestCeremony(), causing the fallback HostTopOriginValidator to always be used during authentication. This broke cross-origin iframe scenarios where topOrigin differs from the host. Fixes #816 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Previously, CheckTopOrigin always validated the top origin using a fallback HostTopOriginValidator when no custom validator was set. This made enableTopOriginValidator() misleading since validation was always active regardless. Now, when no TopOriginValidator is configured, the top origin check is skipped entirely. Calling enableTopOriginValidator() truly enables the validation, matching the method's name and intent. Fixes #816 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TopOriginValidatorset viaenableTopOriginValidator()was passed toCheckTopOriginincreationCeremony()but not inrequestCeremony(). Fixed by passing$this->topOriginValidatorin both ceremonies.enableTopOriginValidator()was misleading: top origin validation was always active via a fallbackHostTopOriginValidator, making the method name suggest it "enables" something that was already on. Now, when noTopOriginValidatoris configured, the top origin check is skipped entirely. CallingenableTopOriginValidator()truly enables the validation.Fixes #816
Test plan
enableTopOriginValidator(), top origin validation is skipped (no strict host comparison)enableTopOriginValidator()with a custom validator activates validation for both creation and request ceremoniestopOrigindiffers fromhostand no top origin validator is configured🤖 Generated with Claude Code